Skip to content

Conversation

@quasystaty1
Copy link
Contributor

Summary

bump celestia_update fork height by one in order to allow for soft_as_firm mode to start executing blocks

@quasystaty1 quasystaty1 requested a review from a team as a code owner October 8, 2025 21:01
@github-actions github-actions bot added the cd label Oct 8, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

This PR implements a targeted fix to enable `soft_as_firm` mode block execution in the flame-testnet configuration by incrementing the `celestia_update` fork height from 12994834 to 12994835. The change addresses a timing synchronization issue where the original fork height was preventing proper block execution in this specific operational mode.

The modification touches three key files in the Helm chart infrastructure: the core genesis configuration file for flame-testnet, and two Chart.yaml files that require version bumps to reflect the configuration change. The celestia_update fork configuration in Astria defines when protocol upgrades take effect, and this single-block adjustment ensures proper alignment with Celestia network state for soft_as_firm execution.

The changes follow established Astria patterns for fork height management and Helm chart versioning practices. The evm-rollup chart version increments from 4.0.1 to 4.0.2, while the evm-stack chart (which depends on evm-rollup) bumps from 5.0.2 to 5.0.3 and updates its dependency reference accordingly. This maintains proper chart dependency synchronization across the deployment infrastructure.

Important Files Changed

Changed Files
Filename Score Overview
charts/evm-rollup/files/genesis/flame-testnet.genesis.json 4/5 Increments celestia_update fork height from 12994834 to 12994835 to fix soft_as_firm mode execution
charts/evm-rollup/Chart.yaml 5/5 Bumps chart version from 4.0.1 to 4.0.2 following Helm versioning practices
charts/evm-stack/Chart.yaml 5/5 Updates chart version to 5.0.3 and dependency reference to evm-rollup 4.0.2

Confidence score: 4/5

  • This PR is safe to merge with minimal risk as it addresses a specific operational issue with a targeted fix
  • Score reflects the focused nature of the change and proper versioning practices, though fork height modifications always carry some inherent risk in blockchain systems
  • Pay close attention to the genesis configuration file to ensure the fork height change aligns with intended network behavior

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants