chore(conductor): remove unnecessary block hashes from test mounts #1973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanoroshiba
added
conductor
ethanoroshiba
commented
Feb 14, 2025
| } | ||
|
|
||
| #[macro_export] | ||
| macro_rules! mount_firm_update_commitment_state { |
There was a problem hiding this comment.
I split this up for readability in tests, but I'm not sure if this makes it too opaque to a reader without context. Happy to change this back if needed.
ethanoroshiba
changed the title
ethanoroshiba
requested review from
SuperFluffy and
joroshiba
as code owners
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or this PR will be |
ethanoroshiba
added
ignore-stale
|
Marking as |
|
Conflicts on stale PR, is it still relevant and need updated or now obsolete? |
|
@joroshiba would still be nice to have, but will take a bit of adjustment with the v2 changes. Will try to get conflicts addressed ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes unnecessary block hashes from test mounts by maintaining current block hashes in
TestConductor.Background
Conductor tests have gotten unruly with the number and specificity of mounts needed to make them function properly. This is meant to make the tests more readable, simpler, and easier to write.
Changes
TestRollupStatetoTestConductor, which keeps track of the current block hash initializers (the repeated number in our test hashes) as well as the current firm block number (in case soft is updated but not firm).mount_update_commitment_stateinto soft and firm variants for readability.Testing
All tests are passing.
Changelogs
No updates requried.
Related Issues
part of #1927