ASPC-35: Fixed grad requirement filter to be compatible with newer updates (and added toggle + warning) #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ellazhuu
changed the title
haram082
requested changes
Nov 9, 2025
| page = 1, | ||
| } = req.query; | ||
|
|
||
| const requirements = req.query.requirements |
Contributor
There was a problem hiding this comment.
you shoudl be putting it in the req.query object and handling it from there
backend/src/routes/CoursesRoutes.ts
Outdated
| } | ||
|
|
||
| // Get fuzzy matches using aggregation | ||
| const fuzzyMatch: any = { |
Contributor
There was a problem hiding this comment.
add requirements to search stage instead of adding another fuzzyMatch function to be consitent with our code. if there is a specfiic reason you did this way, lmk
haram082
approved these changes
Nov 10, 2025
Contributor
haram082
left a comment
haram082
left a comment
There was a problem hiding this comment.
nit: u never addressed "you shoudl be putting it in the req.query object and handling it from there"" but it's not a big deal. the filtering logic you updated looks good. feel free to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Describe your changes
Testing
Screen.Recording.2025-11-08.at.9.52.25.PM.mov