clean code + fix dropdown #183
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New option for info boxes => authorize adaptive width according to content or use Dolibarr mode (fix width) Fix missing english translations
Add hidden options for CKEditor add a process for implementing new fonts: 1 - new font.css => font-face for added fonts 2 - change of config.js to take into account the new fonts in the WYSYWIG editor 3 - added 2 fonts => Puente and Neuropol
fix dropdown
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on code cleanup and fixing dropdown functionality within the Oblyon theme. The main changes include standardizing PHP output syntax and reorganizing CSS structure.
- Standardizes PHP output by replacing
echowithprintthroughout the codebase - Converts hardcoded color values to CSS custom properties (variables) for better maintainability
- Removes duplicated CSS declarations in the login block section
Reviewed Changes
Copilot reviewed 8 out of 41 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| themeoblyon/style.css.php | Fixes variable name casing for $colorstitle |
| themeoblyon/login.inc.php | Converts hardcoded colors to CSS variables and removes extensive duplicated CSS |
| themeoblyon/global.inc.php | Standardizes echo to print and adds missing CSS variable definitions |
| themeoblyon/dropdown.inc.php | Converts hardcoded colors to CSS variables |
| themeoblyon/btn.inc.php | Expands button selector to include additional UI elements |
| sql/data.sql | Removes empty line for cleaner formatting |
| langs/fr_FR/oblyon.lang | Adds CKEditor configuration translation strings |
| langs/en_US/oblyon.lang | Adds CKEditor configuration translation strings |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.