Skip to content

fix: consensus working when there is only one validator #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: consensus working when there is only one validator #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions mempool/src/quorum_waiter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,15 @@ impl QuorumWaiter {
while let Some(stake) = wait_for_quorum.next().await {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this line won't block until a message is received from other validators (which will never happen if there is a single validator)?

total_stake += stake;
if total_stake >= self.committee.quorum_threshold() {
self.tx_batch
.send(batch)
.await
.expect("Failed to deliver batch");
break;
}
}
if total_stake >= self.committee.quorum_threshold() {
self.tx_batch
.send(batch)
.await
.expect("Failed to deliver batch");
}

// Give a bit of extra time to disseminate the batch to slower nodes rather than
// immediately dropping the handles.
Expand Down