Add more test cases for IfStmt and make code simple #48 #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shivamsingh8883 , Please look into the CI errors . The test cases should follow the similar pattern as in test_for_loops.py . |
|
@shivamsingh8883 , i have added test cases for IfStmt, can you please go through them once, and if you still feel the need to add more, reopen the PR and work on the CI errors !? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For adding more test cases to IfStmt class to make sure it works in all cases. Also, I simplified the code a bit by removing extra lines and making it small
Changes made are: 1) Added test cases for conditions and branches that raise exceptions, 2) Removed unnecessary comments and made lambdas shorter, 3) Checked that everything works fine after changes.
Plz review and let me know if anything is wrong. Thanks!