Skip to content

Add support for float32 datatype #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ahmed44374
Copy link
Contributor

@ahmed44374 ahmed44374 commented Mar 19, 2025

Pull Request description

Add support for float datatype

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved .

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ahmed44374 ahmed44374 changed the title Add support for float datatype Add support for float32 datatype Mar 24, 2025
Copy link
Contributor

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmed44374 , thanks for working on that.
in general it looks good to me. could you add more tests for that? it would be nice to have some tests for all the binary operators and with structures like if, for, and function.

@yuvi-mittal
Copy link
Contributor

@ahmed44374 , Can you rebase you branch and push again ?

@ahmed44374
Copy link
Contributor Author

@ahmed44374 , Can you rebase you branch and push again ?

ok sure

@xmnlab xmnlab marked this pull request as draft April 20, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants