Support Java 11 #56
Open
Support Java 11 #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok
On Sat, Jul 25, 2020 at 4:14 PM Arun Yadav ***@***.***> wrote:
moving to java 11.
UpdatableJdbcRowsetImpl.java depends on
com.sun.rowset.JdbcRowSetResourceBundle; which is now considered internal
API post Java 9 and oracle doesn't want us to use it. I have temporarily
bypassed the check through --add-export argument. Going forward we should
move away from this completely.
------------------------------
You can view, comment on, or merge this pull request online at:
#56
Commit Summary
- Support Java 11
File Changes
- *M* pom.xml
<https://github.com/arrahtech/osdq-core/pull/56/files#diff-600376dffeb79835ede4a0b285078036>
(8)
Patch Links:
- https://github.com/arrahtech/osdq-core/pull/56.patch
- https://github.com/arrahtech/osdq-core/pull/56.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#56>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACW3DVVVI7Z2RLPQ2222TGLR5M4JJANCNFSM4PHTYIHA>
.
--
regards,
Vivek Singh
Author of "The Reverse Journey" from Frogbooks
|
|
The option in maven by passes the check for internal api. mvn compile will now build bytecode compatible for java 11. |
|
So only pom.xml change is required or some other code change is also required ? |
|
No code change for now. We are all good. But in future or whenever we have a chance, need to get rid of UpdatableJdbcRowsetImpl.java Though once we compile with target = 11 in pom. The code will only run in java 11+ |
|
Ok. So we can compile two times - one for java 8 another one for java 11
On Sat, Jul 25, 2020 at 4:25 PM Arun Yadav ***@***.***> wrote:
No code change for now. We are all good. But in future or whenever we have
a chance, need to get rid of UpdatableJdbcRowsetImpl.java
Though once we compile with target = 11 in pom. The code will only run in
java 11+
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#56 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACW3DVWZZROJOSSKCIWBJJTR5M5VJANCNFSM4PHTYIHA>
.
--
regards,
Vivek Singh
Author of "The Reverse Journey" from Frogbooks
|
|
Yeps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving to java 11.
UpdatableJdbcRowsetImpl.java depends on com.sun.rowset.JdbcRowSetResourceBundle; which is now considered internal API post Java 9 and oracle doesn't want us to use it. I have temporarily bypassed the check through --add-export argument. Going forward we should move away from this completely.