FEATURE: add a snap flag to enable snapping to plausible steps on inc & dec in TimeView #603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm referencing the original issue from another repo here: neos/neos-ui#2247 to see where the idea originated.
I added a feature behind a flag called
snapwhich when enabled slightly alters the way theincreaseanddecreasemethods ofTimeViewwork.The flag is optional and completely backwards compatible so there are no breaking changes.
Motivation and Context
When the user uses the
todaybutton he sets the time to now which, for example, could be00:12.With
stepforminutesset to5theincreaseordecreasebuttons on minutes it will step to00:17or00:07respectively.With
snapenabled it will snap to the next plausible value depending onstep, e.g.00:15and00:10respectively.Checklist