fix: follow what Argo CD does and set the rolebinding namespace to argocd #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeshng
requested review from
jannfis,
jgwest and
chetan-rns
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #575 +/- ##
==========================================
+ Coverage 44.52% 44.91% +0.39%
==========================================
Files 90 90
Lines 11909 12016 +107
==========================================
+ Hits 5302 5397 +95
- Misses 6174 6176 +2
- Partials 433 443 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jannfis
reviewed
Sep 21, 2025
| #### Troubleshooting | ||
| ___ | ||
|
|
||
| 1. If pod fails to come up with error |
There was a problem hiding this comment.
I do not think this should go. This will happen at any time when the namespace in the (cluster-)rolebinding does not match the installation namespace.
There was a problem hiding this comment.
You are right. Reverted.
…gocd for both principal and agent Signed-off-by: Mike Ng <[email protected]>
mikeshng
force-pushed
the
fix-binding-ns
branch
from
8a47c3f to
2ddbb2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / why we need it:
Follow what Argo CD does and set the rolebinding namespace to argocd for both principal and agent
See #542 (comment) for more details.
This default ns has been pretty annoying when setting up the argocd-agent env for some time now. Following the setup/installation steps is arguably the hardest part of this project, so we should make it as simple as possible for beginners.
Which issue(s) this PR fixes:
Fixes #403
How to test changes / Special notes to the reviewer:
Checklist