[AE-13] Add CO2 and IAQ data from SensorBSEC class #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
topic: documentation
|
Memory usage change @ d494cf5
Click for full report table
Click for full report CSV |
|
Memory usage change @ 896d7db
Click for full report table
Click for full report CSV |
aliphys
commented
Jun 7, 2023
Comment on lines
47
to
48
| Serial.println(String("co2: ") + String(bsec.co2_eq(),3)); | ||
| Serial.println(String("iaq: ") + String(bsec.iaq(),3)); |
There was a problem hiding this comment.
Following @alrvid 's comment, the following two lines are problematic. The data types of the SenseBSEC class are not uniform and are either unit8_t, unit16_t, unit32_t or float. See here.
uint16_t iaq() {return _data.iaq;}
uint16_t iaq_s() {return _data.iaq_s;}
float b_voc_eq() {return _data.b_voc_eq;}
uint32_t co2_eq() {return _data.co2_eq;}
uint8_t accuracy() {return _data.accuracy;}
float comp_t() {return _data.comp_t;}
float comp_h() {return _data.comp_h;}
uint32_t comp_g() {return _data.comp_g;}
There was a problem hiding this comment.
String(val, decimalPlaces) can only be used for certain data types:
`val`: a variable to format as a String - *Allowed data types:* string, char, byte, int, long, unsigned int, unsigned long, float, double +
So unit8_t, unit16_t and unit32_t are illegal.
|
The problem isn't with the val parameter - it's with the second parameter you pass to String(), called decimalPlaces. That parameter can only be used when the first parameter (val) is a float or double. In your case, you pass a uint32_t as the first parameter (the value), so you can't pass a second parameter at all. So, of these four lines, the first two are illegal: Serial.println(String("co2: ") + String(bsec.co2_eq(),3)); The last two should work. It's not a problem that co2_eq() returns uint32_t, because the Arm GCC compiler carries with it this typedef in a header file: typedef UINT32_TYPE __uint32_t; And UINT32_TYPE is a built-in macro in GCC that's defined as the underlying 32-bit unsigned data type of the platform. And as you noted, unsigned int is a valid type for val, and it is also an unsigned 32-bit data type on the Cortex-M platform. So you should be able to pass a uint32_t as the first parameter. The problem is that you can't do this: Serial.println(String("co2: ") + String(bsec.co2_eq(),3)); Only this is valid: Serial.println(String(bsec.co2_eq())); |
aliphys
commented
Jun 7, 2023
Remove 'decimalPlaces' parameter
|
Memory usage change @ 5835471
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added CO2 and IAQ output to the Serial Monitor based on the
SensorBSECclass to theStandalone.inotest sketch.Note: Do not merge, until #82 is resolved.
Pull request type