Skip to content

Order custom board option menus as defined in platform configuration #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Order custom board option menus as defined in platform configuration #2717

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62aee5c
Fix for Issue 2036
gneiss15 Apr 22, 2025
e295573
Fix Error produced by "Actions"
gneiss15 Apr 22, 2025
27a46a4
Now it's working
gneiss15 Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions arduino-ide-extension/src/browser/contributions/boards-data-menu-updater.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ import { inject, injectable } from '@theia/core/shared/inversify';
import PQueue from 'p-queue';
import {
BoardIdentifier,
ConfigOption,
// Produces Error: src/browser/contributions/boards-data-menu-updater.ts(10,3): error TS6133: 'ConfigOption' is declared but its value is never read.
// ConfigOption,
isBoardIdentifierChangeEvent,
Programmer,
} from '../../common/protocol';
Expand Down Expand Up @@ -71,9 +72,7 @@ export class BoardsDataMenuUpdater extends Contribution {
...ArduinoMenus.TOOLS__BOARD_SETTINGS_GROUP,
'z01_boardsConfig',
]; // `z_` is for ordering.
for (const { label, option, values } of configOptions.sort(
ConfigOption.LABEL_COMPARATOR
)) {
for (const { label, option, values } of configOptions ) {
const menuPath = [...boardsConfigMenuPath, `${option}`];
const commands = new Map<
string,
Expand Down
Loading