-
-
Notifications
You must be signed in to change notification settings - Fork 213
AE-591: Created patch to remove the call to "enableEthPowerSupply" fr… #1088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AE-591: Created patch to remove the call to "enableEthPowerSupply" fr… #1088
Conversation
…om "HAL_ETH_MspInit" when building the Portenta H7 variant.
@bogdanarduino will ethernet work using bootloader 25 (or even previous versions) and removing I would wait to officialy release the bootloader 26 before adding the bootloader dump in the core, to make sure we are using the exact same binary. |
Yes, Ethernet functionality should be unaffected by these changes, since the bootloader only contains a fix for the nominal voltages being output by the board's PMIC DC-DC stage, but the rails are nevertheless still being turned on automatically during start-up, by the config of the OTP registers of the PMIC. What we did here is to remove the call to this, basically redundant function, which made absolutely sure that we have power supplied to the PHY before going to low power (stand-by) mode. We now moved the call to "turnOffEthernet" in the function which sets all the peripherals to low power "setAllPeripheralsPower(false). |
Should I then remove the new bootloader form the header? Thank you very much for the comments! |
Yes please |
d2a7938
to
a9a2246
Compare
@pennam Have we already scheduled a release? |
@sebromero no, I guess this is the only change we need to include. If so we can merge it as soon as is ready and create a pre-release of the binary to allow testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Created patch to remove the call to "enableEthPowerSupply" from "HAL_ETH_MspInit" when building the Portenta H7 variant.
And introduced new bootloader binary in "STM32H747_manageBootloader.ino".