Skip to content

Conversation

@ZR233
Copy link
Contributor

@ZR233 ZR233 commented Sep 8, 2025

refactor: add page level detect and remove feature
@ZR233 ZR233 requested review from aarkegz, Copilot and hky1999 September 8, 2025 07:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes IRQ settings in the ARMv8 hypervisor implementation by refactoring the VTCR_EL2 configuration, improving IRQ handling, and cleaning up dependencies.

  • Replaces conditional compilation for EPT paging with runtime VTCR_EL2 probing
  • Fixes IRQ/FIQ handling by properly configuring HCR_EL2 settings
  • Removes unused dependencies and cleans up imports

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/vcpu.rs Refactors VTCR_EL2 setup with runtime probing and fixes IRQ configuration
src/pcpu.rs Removes hardcoded IRQ/FIQ settings from hardware enable
src/exception_utils.rs Simplifies imports by using wildcard import
Cargo.toml Reorganizes metadata and removes unused tock-registers dependency
.cargo/config.toml Adds build target configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants