add some logs to help debug Arcadia start up time #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unity sets System.AppDomain.CurrentDomain.BaseDirectory to null which causes all kinds of problems.
Raises NotImplemented exceptions in Unity otherwise. Refs and MultiFns are broken as a result.
Unity sets System.AppDomain.CurrentDomain.BaseDirectory to null which causes all kinds of problems.
Raises NotImplemented exceptions in Unity otherwise. Refs and MultiFns are broken as a result.
Use superclass in place of stub class for type hinting
This is a port of @ztellman's pending patch http://dev.clojure.org/jira/browse/CLJ-1529 This patch avoids unnecessary lookups on symbols that are known to be lexically bound, resulting in significant speedup in many cases. Details are on the Jira page.
Namespace qualified types skip the slow string comparison code path. This commit also documents when each lookup path can be expected to succeed.
The logic that was in the static constructor was moved to an instance method that can be called from the Awake method. This was done to avoid Unity's inability to guarantee the order that static constructors will be called in. The new method is named "CarlylesMouse" on the principled insistence of Tims Gardner who, while striking the arm of Ramsey Nasser repeatedly, made the case that "No, it is not a Static Constructor. It is a mouse. It belongs to Carlyle. It's CarlylesMouse." His wisdom stands.
Fixes protocol loading bugs
Lookups for unqualified, unimported types will throw an exception (as they should). This patch removes lookup logic that was in place due to a mono bug where types with slashes in their names could not be found. The compiler no longer emits such types, so the slow path is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.