Fix synchronization of injection #445
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
agheata
approved these changes
Oct 3, 2025
Contributor
agheata
left a comment
agheata
left a comment
There was a problem hiding this comment.
🤞 that this fixes the injection forever
Contributor
|
Is this expected: |
Collaborator
Author
It fails in SYNC adept which was not touched at all, it very rarely does this. |
Contributor
|
@SeverinDiederichs is this tested and ready for merging? |
Collaborator
Author
|
No, not yet, as I need to dig up some old athena version which was the only one giving a reliable reproducer of the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description will follow, extensive tests are ongoing