Updates for Modern 8.0 #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egreer
reviewed
Oct 11, 2024
egreer
approved these changes
Dec 19, 2024
wkirby
force-pushed
the
feature/updates
branch
from
3a76139 to
c535fbb
Compare
egreer
requested changes
Aug 25, 2025
Gemfile
Outdated
| gem 'rubocop-performance', require: false | ||
| gem 'rubocop-rails', require: false | ||
| gem "rubocop-rails-omakase", require: false |
There was a problem hiding this comment.
Styling inconsistency in here did we drop prettier?
egreer
approved these changes
Aug 25, 2025
| @@ -5,10 +5,10 @@ | |||
|
|
|||
| # Reveal health status on /up that returns 200 if the app boots with no exceptions, otherwise 500. | |||
| # Can be used by load balancers and uptime monitors to verify that the app is live. | |||
| get "up" => "rails/health#show", as: :rails_health_check | |||
| get "up" => "rails/health#show", :as => :rails_health_check | |||
There was a problem hiding this comment.
Why did it choose this syntax? Is it just trying to be consistent on the same line?
egreer
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.