Skip to content

Removed docker and swiftformat references #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Removed docker and swiftformat references #1206

wants to merge 4 commits into from

Conversation

akbashev
Copy link
Contributor

@akbashev akbashev commented May 1, 2025

After moving to GitHub actions repo is:

  1. Using swift-format, so having swiftformat alongside is confusing for contributing.
  2. Docker compose is not needed anymore.

Motivation:

Improve contributing experience.

Modifications:

  1. Removed swiftformat configuration file and script
  2. Removed .docker folder
  3. Updated .devcontainer configuration

and
4. Added .vscode to gitignore—while checking in VSCode realized configs are not ignored.

simonjbeaumont
simonjbeaumont approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@simonjbeaumont simonjbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@simonjbeaumont simonjbeaumont added the semver/none No version bump required. label May 9, 2025
@simonjbeaumont simonjbeaumont enabled auto-merge (squash) May 9, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjbeaumont simonjbeaumont simonjbeaumont approved these changes

Assignees
No one assigned
Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akbashev @simonjbeaumont @ktoso