-
Notifications
You must be signed in to change notification settings - Fork 152
Create unpacker protocol + ext4 unpacker #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adityaramani
wants to merge
1
commit into
apple:main
Choose a base branch
from
adityaramani:unpacker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 84 additions & 0 deletions
84
Sources/Containerization/Image/Unpacker/EXT4Unpacker.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
//===----------------------------------------------------------------------===// | ||
// Copyright © 2025 Apple Inc. and the Containerization project authors. All rights reserved. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// https://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
//===----------------------------------------------------------------------===// | ||
|
||
import ContainerizationError | ||
import ContainerizationExtras | ||
import ContainerizationOCI | ||
import Foundation | ||
|
||
#if os(macOS) | ||
import ContainerizationArchive | ||
import ContainerizationEXT4 | ||
import SystemPackage | ||
#endif | ||
|
||
public struct EXT4Unpacker: Unpacker { | ||
let blockSizeInBytes: UInt64 | ||
|
||
public init(blockSizeInBytes: UInt64) { | ||
self.blockSizeInBytes = blockSizeInBytes | ||
} | ||
|
||
public func unpack(_ image: Image, for platform: Platform, at path: URL, progress: ProgressHandler? = nil) async throws -> Mount { | ||
#if !os(macOS) | ||
throw ContainerizationError(.unsupported, message: "Cannot unpack an image on current platform") | ||
#else | ||
let blockPath = try prepareUnpackPath(path: path) | ||
let manifest = try await image.manifest(for: platform) | ||
let filesystem = try EXT4.Formatter(FilePath(path), minDiskSize: blockSizeInBytes) | ||
defer { try? filesystem.close() } | ||
|
||
for layer in manifest.layers { | ||
try Task.checkCancellation() | ||
let content = try await image.getContent(digest: layer.digest) | ||
|
||
switch layer.mediaType { | ||
case MediaTypes.imageLayer, MediaTypes.dockerImageLayer: | ||
try filesystem.unpack( | ||
source: content.path, | ||
format: .paxRestricted, | ||
compression: .none, | ||
progress: progress | ||
) | ||
case MediaTypes.imageLayerGzip, MediaTypes.dockerImageLayerGzip: | ||
try filesystem.unpack( | ||
source: content.path, | ||
format: .paxRestricted, | ||
compression: .gzip, | ||
progress: progress | ||
) | ||
default: | ||
throw ContainerizationError(.unsupported, message: "Media type \(layer.mediaType) not supported.") | ||
} | ||
} | ||
|
||
return .block( | ||
format: "ext4", | ||
source: blockPath, | ||
destination: "/", | ||
options: [] | ||
) | ||
#endif | ||
} | ||
|
||
private func prepareUnpackPath(path: URL) throws -> String { | ||
let blockPath = path.absolutePath() | ||
guard !FileManager.default.fileExists(atPath: blockPath) else { | ||
throw ContainerizationError(.exists, message: "block device already exists at \(blockPath)") | ||
} | ||
return blockPath | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
//===----------------------------------------------------------------------===// | ||
// Copyright © 2025 Apple Inc. and the Containerization project authors. All rights reserved. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// https://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
//===----------------------------------------------------------------------===// | ||
|
||
import ContainerizationExtras | ||
import ContainerizationOCI | ||
import Foundation | ||
|
||
/// The `Unpacker` protocol defines a standardized interface that involves | ||
/// decompressing, extracting image layers and preparing it for use. | ||
/// | ||
/// The `Unpacker` is responsible for managing the lifecycle of the | ||
/// unpacking process, including any temporary files or resources, until the | ||
/// `Mount` object is produced. | ||
protocol Unpacker { | ||
|
||
/// Unpacks the provided image to a specified path for a given platform. | ||
/// | ||
/// This asynchronous method should handle the entire unpacking process, from reading | ||
/// the `Image` layers for the given `Platform` via its `Manifest`, | ||
/// to making the extracted contents available as a `Mount`. | ||
/// Implementations of this method may apply platform-specific optimizations | ||
/// or transformations during the unpacking. | ||
/// | ||
/// Progress updates can be observed via the optional `progress` handler. | ||
func unpack(_ image: Image, for platform: Platform, at path: URL, progress: ProgressHandler?) async throws -> Mount | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,6 +98,13 @@ extension Application { | |
|
||
@Option(name: .customLong("platform"), help: "Platform string in the form 'os/arch/variant'. Example 'linux/arm64/v8', 'linux/amd64'") var platformString: String? | ||
|
||
@Option( | ||
name: .customLong("unpack-path"), help: "Path to unpack image into", | ||
transform: { str in | ||
URL(fileURLWithPath: str, relativeTo: .currentDirectory()).absoluteURL.path(percentEncoded: false) | ||
}) | ||
var unpackPath: String? | ||
|
||
@Flag(help: "Pull via plain text http") var http: Bool = false | ||
|
||
func run() async throws { | ||
|
@@ -126,11 +133,20 @@ extension Application { | |
} | ||
|
||
print("image pulled") | ||
guard let unpackPath else { | ||
return | ||
} | ||
guard !FileManager.default.fileExists(atPath: unpackPath) else { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this also returns true if the path is a directory, do we still want to error? |
||
throw ContainerizationError(.invalidArgument, message: "File exists at \(unpackPath)") | ||
} | ||
let unpackUrl = URL(filePath: unpackPath) | ||
try FileManager.default.createDirectory(at: unpackUrl, withIntermediateDirectories: true) | ||
|
||
let unpacker = EXT4Unpacker.init(blockSizeInBytes: 2.gib()) | ||
|
||
let tempDir = FileManager.default.uniqueTemporaryDirectory(create: true) | ||
if let platform { | ||
let name = platform.description.replacingOccurrences(of: "/", with: "-") | ||
let _ = try await image.unpack(for: platform, at: tempDir.appending(component: name)) | ||
let _ = try await unpacker.unpack(image, for: platform, at: unpackUrl.appending(component: name)) | ||
} else { | ||
for descriptor in try await image.index().manifests { | ||
if let referenceType = descriptor.annotations?["vnd.docker.reference.type"], referenceType == "attestation-manifest" { | ||
|
@@ -140,11 +156,10 @@ extension Application { | |
continue | ||
} | ||
let name = descPlatform.description.replacingOccurrences(of: "/", with: "-") | ||
let _ = try await image.unpack(for: descPlatform, at: tempDir.appending(component: name)) | ||
let _ = try await unpacker.unpack(image, for: descPlatform, at: unpackUrl.appending(component: name)) | ||
print("created snapshot for platform \(descPlatform.description)") | ||
} | ||
} | ||
try? FileManager.default.removeItem(at: tempDir) | ||
} | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Given both the unpacks are the exact same besides whether they supply compression or not, can we just assign a compression variable in the switch cases and then do the unpack outside of it?