Add containerization extras tests #148
Open
+1,155
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tras - Enhanced IPv4Address documentation with comprehensive examples and parameter descriptions - Improved error messages in NetworkAddressError with actionable guidance - Added detailed documentation for CIDRAddress including usage examples and method descriptions - Expanded AsyncLock documentation with use cases and threading safety information - Enhanced Timeout documentation with implementation details and performance notes - Improved error message clarity in Timeout.swift by replacing generic fatalError These changes make the API more accessible to new contributors and provide better developer experience through clear error messages and comprehensive documentation.
…s - Added TestAsyncLock.swift with 13 test cases covering concurrent access, error handling, FIFO ordering, and performance - Added TestTimeout.swift with 15 test cases covering timeout behavior, error propagation, and edge cases - Tests ensure thread safety, proper cancellation, and accurate timeout behavior - Improves test coverage for ContainerizationExtras module - All tests use modern Swift Testing framework with async/await patterns
…Fixed all Sendable protocol conformance issues in test structs - Replaced throwing closures with non-throwing ones for Timeout.run compatibility - Used actors for thread-safe shared state in concurrent tests - Resolved generic type conflicts in AsyncLock performance tests - Added proper error handling patterns using Result types - Ensured all async operations use proper concurrency patterns
|
This is awesome! I'll take a look at this sometime between today and tomorrow. Thanks a ton! |
dcantah
reviewed
Jun 18, 2025
| group.addTask { | ||
| await lock.withLock { context in | ||
| await tracker.append("task1-start") | ||
| try? await Task.sleep(nanoseconds: 50_000_000) // 50ms |
There was a problem hiding this comment.
Task.sleep has a for: constructor that takes in enums for different time intervals and should look much nicer:
try await Task.sleep(for: .milliseconds(50))
There was a problem hiding this comment.
Same advice for the other sleeps
|
@dkovba Wanna look at the AsyncLock documentation updates here? |
dkovba
reviewed
Jun 19, 2025
| /// await lock.withLock { context in | ||
| /// // Async operations are safe within the lock | ||
| /// let processedName = await processResourceName(name) | ||
| /// resources.append(processedName) |
There was a problem hiding this comment.
Should we add func appendResource(_ resource: String, context: AsyncLock.Context) to demonstrate how context is used? The required context parameter ensures that the function is called only inside a lock.
| /// A context object provided to closures executed within the lock. | ||
| /// | ||
| /// The context serves as proof that the code is executing within the lock's | ||
| /// critical section. While currently empty, it may be extended in the future |
There was a problem hiding this comment.
It is empty by design because this is sufficient to serve as proof that the code is executed within the lock.
|
Please run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please verify, it requires Swift 6.2 to run, which aligns with the project's stated requirements.
📋 Test Coverage Created
Edge cases (zero timeout, large timeout, consecutive timeouts)