Fix image push tests permissions in CI #128
Open
+404
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Will take a deeper look and get back! In the meantime could you please set up commit signing and re push your commits? |
Replace disabled external registry push tests with mock-based tests that don't require registry write permissions. Changes: - Replace testImageStorePush() with testImageStorePushWithMock() - Replace pushIndex() with pushIndexWithMock() - Add MockRegistryClient implementing ContentClient protocol - Add testPush() extension method for dependency injection - Fix Makefile Swift path for environment compatibility This enables external contributors to run complete test suite without registry credentials. Resolves apple#56
Siddhant-K-code
force-pushed
the
fix/image-push-tests-permissions
branch
from
0b27707 to
825f0ad
Compare
|
Thanks, I've signed the commit |
- Add Hashable conformance to Descriptor struct for dictionary key usage - Add missing imports: ContainerizationError, Crypto, NIOCore - Fix SHA256Digest type references to SHA256.Digest - Fix MockRegistryClient Sendable conformance with @unchecked Sendable - Fix Image.Config/Image.Rootfs references to ImageConfig/Rootfs - Fix progress handler usage to match ProgressHandler signature - Fix nil type context annotations for progress parameters
Siddhant-K-code
force-pushed
the
fix/image-push-tests-permissions
branch
from
c2b4575 to
f044c26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a mock-based testing approach that validates push functionality without requiring external registry permissions.
fixes #56