fix: correct release condition in GitHub Actions and globalize enviro… #127
+22
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor GitHub Actions Workflow: Containerization Build
🛠 Summary
This PR introduces several important improvements and cleanups to the build-containerization-template GitHub Actions workflow for better maintainability, correctness, and readability.
🔧 Changes Made
1. ✅ Fix invalid conditional syntax
!= is not supported in expressions with if: in GitHub Actions.
Only logical operators like !, &&, || are valid.
2. ✅ Globalized environment variables
Moved CURRENT_SDK and DEVELOPER_DIR to the job-level env: block to:
Avoid redundancy across steps
Make the workflow more maintainable
3. ✅ Replaced
secrets.GITHUB_TOKENwithgithub.token@katiewasnothere