Skip to content

TST,BLD,BUG: if __name__=='__main__': __main__.main(argv) and tests #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: boss
Choose a base branch
from

Conversation

westurner
Copy link

  • fix asciifx console_script so that pip -e . works
  • tests for main(argv=["--help"])

@westurner
Copy link
Author

I changed 'ascii-fx' to 'asciifx', because it already doesn't have a dash in pyproject.yml:
https://github.com/apparebit/asciifx/pull/2/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R37

apparebit added a commit that referenced this pull request Feb 1, 2025
…t-based tests and returning meaningful error codes
@apparebit
Copy link
Owner

Thank you for the pull request.

I just pushed an update that incorporates most of your changes.

Except, I omitted the tests because they strike me as overkill (live a little 🤪). Plus, I strongly dislike pytest, which performs far too much magic for a test runner. I'm surprised that you didn't add it to the optional dependencies.

I also added code to actually return meaningful error codes and not always 0.

If the changes meet your needs, I'll publish a new version of the package and close this pull request.

@westurner
Copy link
Author

westurner commented Feb 2, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants