Add a no-single-quotes rule to enforce a fancy closing single quote #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a rule that we find useful in our static
gettext
translation. From a design perspective, we want to only use the fancy single quote (closing single quote) and disallow the regular single quote that engineers usually use everywhere. It is more typographically sound. https://practicaltypography.com/straight-and-curly-quotes.htmlThis library is wonderful and is a great place to put this
gettext
style enforcement. I mostly copied the existing implementation.