Skip to content

SECOPS-2268: Add Gitleaks to CI #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2023
Merged

SECOPS-2268: Add Gitleaks to CI #314

merged 1 commit into from
Oct 12, 2023

Conversation

svc-secops
Copy link
Contributor

Motivation / Implements

This PR adds the necessary files to configure Gitleaks to run on PRs on this repo. The Apollo Security team uses Gitleaks to test our repositories for secrets.

Once this is accepted and merged, the Security team plans to make a passing Gitleaks check a requirement for PRs to merge into this repo. This will prevent secrets from being introduced to our repos.

In the event that a secret is detected on a repo, the CI job will add a comment to the PR associated with the detection to provide instructions on how to properly resolve the detection. Additionally, if a secret is detected, the Apollo Security team will be notified so that we can be available to assist in resolving the detection.

If maintainers reviewing this PR have questions, please see this Apollo-internal Slack link.

Changed

  • Added .circleci/config.yml to this repo. This file contains appropriate configuration to enable Gitleaks as a CI check.

Copy link
Collaborator

@fbartho fbartho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @svc-secops — can you please have a human in Apollo’s chain of command verify you’re a legitimate bot account and that this PR is legit?

I have no objections, but I have no way to verify your credentials at this time. There have been fake dependabot PRs lately that try to hack into popular repos, so I need either a page on Apollo’s sites that affirms you’re a legit bot, or a personal communication from somebody I can verify is authorized to sign-off on your changes.

Thanks!

@peakematt
Copy link
Contributor

Hi @fbartho This PR was generated by me via the svc-secops creds! 😄

@peakematt peakematt marked this pull request as ready for review October 12, 2023 16:54
@fbartho fbartho merged commit ea9b08e into master Oct 12, 2023
@fbartho
Copy link
Collaborator

fbartho commented Oct 12, 2023

Thanks @peakematt! Silly question, but do you have any explanation for me about this? #313 (comment)

@fbartho fbartho deleted the secops/add-gitleaks branch October 12, 2023 17:03
@peakematt
Copy link
Contributor

@fbartho If #313 caused problems, I'm so sorry! We've been working to get Renovate running on our repos in a more uniform way and with a wider implementation. I think perhaps the instance of Renovate we're using saw the existing Renovate config file on the repo and ran with it? We have a slightly more opinionated Renovate config set as the default than the Renovate Github app uses. I'm happy to help revert that PR, disable Renovate from running on this repo, and/or help migrate the repo to the Renovate Github app if you'd like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants