Update mrt_lap_times_years.sql #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![senior-dev-bot[bot]](https://avatars.githubusercontent.com/in/282840?s=60&v=4){kind=small}
Comment on lines
14
to
22
| lap, | ||
| lap_time_milliseconds | ||
| from lap_times | ||
| left join races | ||
| leftjoin races | ||
| on lap_times.race_id = races.race_id | ||
| where lap_time_milliseconds is not null | ||
| ) | ||
| select * from expanded_lap_times_by_year No newline at end of file | ||
| select * from expanded_lap_times_by_year |
There was a problem hiding this comment.
Make sure to use correct SQL syntax. The keyword is LEFT JOIN not leftjoin. Using incorrect syntax can cause unexpected errors or behavior.
from lap_times
- leftjoin races
+ LEFT JOIN racesAlso, best practice is to include a newline at the end of files to avoid version control issues.
+select * from expanded_lap_times_by_year
\n
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
To-do before merge
Screenshots:
Validation of models:
Changes to existing models:
Checklist:
{%- if project.warehouse == 'redshift' %}
{% endif %}