2025-06-24 dev branch #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for debug-level logging being turned on selectively at dev time
* Populate location information from RBS files The 'rbs' gem maps the location of different definitions to the relevant point in the RGS files themselves - this change provides the ability to jump into the right place in those files to see the type definition via the LSP. * Prefer source location in language server * Resolve merge issue * Fix Path vs String type error
* Consolidate parameter handling into Pin::Closure * Clarify clobbered variable names * Fix bug in to_rbs, add spec, then fix new bug found after running spec * Catch one more Signature.new to translate from strict typechecking * Introduce Pin::Callable * Introduce Pin::Callable * Introduce Pin::Callable * Introduce Pin::Callable * Introduce Pin::Callable * Introduce Pin::Callable * Introduce Pin::Callable * Use Pin::Callable type in args_node.rb * Select String#each_line overload with mandatory vs optional arg info
…astwide#864) * Adjust local variable presence to start after assignment, not before * Add regression test around assignment in return position * Fix assignment visibility code, which relied on bad asgn semantics
* Resolve params from ref tags * Resolve ref tags with namespaces
This seems to be the most clear mapping - viewing these three names as all meaning 'I am making no promises on what type this can be'. https://github.com/ruby/rbs/blob/master/docs/syntax.md#base-types 'untyped' is used in RBS as the initial type inserted for all arguments and return values when stubs are generated Also: * Refactor RbsMap::Conversions into a standalone class for testing purposes
|
No regressions found in the solargraph-rails specs: iftheshoefritz/solargraph-rails#135 |
* [regression] Only log when we are actually doing work caching pins * [regression] Fix misspelled mutex-y variable name in gem caching - probably fixes castwide#976 * [regression] Speed up 'solargraph gems' caching by only loading api_map once, avoiding extra loading of files from disk * [regression] Use existing pattern to keep only one cache of combined pins in memory, instead of one per DocMap (~0.25s speed-up in solargraph project per docmap on my computer, ymmv)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my 'ready to go improvements' alpha-quality branch that I use to develop future PRs against without duplicating too much work with existing ones.
Things incorporated:
To do: