Skip to content

Caching experiments #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Caching experiments #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
75278f1
Set up initial caching
apiology Oct 12, 2025
f814d82
Ensure bundles are cached
apiology Oct 12, 2025
aa0833a
Cache gems in rspec workflow
apiology Oct 12, 2025
333d732
Deal with failing workflow
apiology Oct 12, 2025
c2d9490
Bump cache
apiology Oct 12, 2025
a792996
Drop 'latest' config
apiology Oct 12, 2025
38e49d9
Move back to latest bundler
apiology Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/linting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ jobs:
run: |
bundle update rbs # use latest available for this Ruby version

- name: Restore cache of gem annotations
- name: Cache gem annotations
id: dot-cache-restore
uses: actions/cache/restore@v4
uses: actions/cache@v4
with:
key: |
2025-06-26-09-${{ runner.os }}-dot-cache-${{ hashFiles('Gemfile.lock') }}
Expand All @@ -67,6 +67,7 @@ jobs:
with:
ruby-version: '3.3'
bundler-cache: true
cache-version: 2025-06-06
- uses: reviewdog/action-rubocop@fcb74ba274da10b18d038d0bcddaae3518739634 # v2.21.2
with:
reporter: github-pr-check
Expand All @@ -87,7 +88,8 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.4
bundler-cache: false
bundler-cache: true
cache-version: 2025-06-06

- name: Install gems
run: bundle install
Expand All @@ -104,7 +106,8 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.4
bundler-cache: false
bundler-cache: true
cache-version: 2025-06-06

- name: Install gems
run: bundle install
Expand Down
51 changes: 50 additions & 1 deletion .github/workflows/plugins.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
with:
ruby-version: '3.0'
bundler-cache: true
cache-version: 2025-06-06
- uses: awalsh128/cache-apt-pkgs-action@latest
with:
packages: yq
Expand All @@ -35,6 +36,17 @@ jobs:
echo 'gem "solargraph-rspec"' >> .Gemfile
bundle install
bundle update rbs
- name: Cache gem annotations
id: dot-cache-restore
uses: actions/cache@v4
with:
key: |
2025-06-26-09-${{ runner.os }}-dot-cache-${{ hashFiles('Gemfile.lock') }}
restore-keys: |
2025-06-26-09-${{ runner.os }}-dot-cache
2025-06-26-09-${{ runner.os }}-dot-cache-
path: |
/home/runner/.cache/solargraph
- name: Configure to use plugins
run: |
bundle exec solargraph config
Expand All @@ -56,6 +68,7 @@ jobs:
with:
ruby-version: '3.0'
bundler-cache: false
cache-version: 2025-06-06
- uses: awalsh128/cache-apt-pkgs-action@latest
with:
packages: yq
Expand All @@ -69,6 +82,17 @@ jobs:
run: |
bundle exec solargraph config
yq -yi '.plugins += ["solargraph-rails"]' .solargraph.yml
- name: Cache gem annotations
id: dot-cache-restore
uses: actions/cache@v4
with:
key: |
2025-06-26-09-${{ runner.os }}-dot-cache-${{ hashFiles('Gemfile.lock') }}
restore-keys: |
2025-06-26-09-${{ runner.os }}-dot-cache
2025-06-26-09-${{ runner.os }}-dot-cache-
path: |
/home/runner/.cache/solargraph
- name: Install gem types
run: bundle exec rbs collection update
- name: Ensure typechecking still works
Expand All @@ -85,6 +109,7 @@ jobs:
with:
ruby-version: '3.0'
bundler-cache: false
cache-version: 2025-06-06
- uses: awalsh128/cache-apt-pkgs-action@latest
with:
packages: yq
Expand All @@ -98,6 +123,17 @@ jobs:
run: |
bundle exec solargraph config
yq -yi '.plugins += ["solargraph-rspec"]' .solargraph.yml
- name: Cache gem annotations
id: dot-cache-restore
uses: actions/cache@v4
with:
key: |
2025-06-26-09-${{ runner.os }}-dot-cache-${{ hashFiles('Gemfile.lock') }}
restore-keys: |
2025-06-26-09-${{ runner.os }}-dot-cache
2025-06-26-09-${{ runner.os }}-dot-cache-
path: |
/home/runner/.cache/solargraph
- name: Install gem types
run: bundle exec rbs collection update
- name: Ensure typechecking still works
Expand All @@ -119,7 +155,8 @@ jobs:
# uses: ruby/setup-ruby@v1
# with:
# ruby-version: '3.0'
# bundler-cache: false
# bundler-cache: true
# cache-version: 2025-06-06
# - name: Install gems
# run: |
# cd ../solargraph-rspec
Expand All @@ -146,9 +183,21 @@ jobs:
# solargraph-rails supports Ruby 3.0+
ruby-version: '3.0'
bundler-cache: false
cache-version: 2025-06-06
bundler: latest
env:
MATRIX_RAILS_VERSION: "7.0"
- name: Cache gem annotations
id: dot-cache-restore
uses: actions/cache@v4
with:
key: |
2025-06-26-09-${{ runner.os }}-dot-cache-${{ hashFiles('Gemfile.lock') }}
restore-keys: |
2025-06-26-09-${{ runner.os }}-dot-cache
2025-06-26-09-${{ runner.os }}-dot-cache-
path: |
/home/runner/.cache/solargraph
- name: Install gems
run: |
set -x
Expand Down
17 changes: 15 additions & 2 deletions .github/workflows/rspec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
bundler-cache: false
bundler-cache: true
cache-version: 2025-06-06
- name: Set rbs version
run: echo "gem 'rbs', '${{ matrix.rbs-version }}'" >> .Gemfile
# /home/runner/.rubies/ruby-head/lib/ruby/gems/3.5.0+2/gems/rbs-3.9.4/lib/rbs.rb:11:
Expand All @@ -48,6 +49,17 @@ jobs:
run: |
bundle install
bundle update rbs # use latest available for this Ruby version
- name: Cache gem annotations
id: dot-cache-restore
uses: actions/cache@v4
with:
key: |
2025-06-26-09-${{ runner.os }}-dot-cache-${{ hashFiles('Gemfile.lock') }}
restore-keys: |
2025-06-26-09-${{ runner.os }}-dot-cache
2025-06-26-09-${{ runner.os }}-dot-cache-
path: |
/home/runner/.cache/solargraph
- name: Run tests
run: bundle exec rake spec
undercover:
Expand All @@ -62,7 +74,8 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.4'
bundler-cache: false
bundler-cache: true
cache-version: 2025-06-06
- name: Install gems
run: bundle install
- name: Run tests
Expand Down
14 changes: 13 additions & 1 deletion .github/workflows/typecheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,23 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.4
bundler-cache: false
bundler-cache: true
cache-version: 2025-06-06
- name: Install gems
run: |
bundle install
bundle update rbs # use latest available for this Ruby version
- name: Cache gem annotations
id: dot-cache-restore
uses: actions/cache@v4
with:
key: |
2025-06-26-09-${{ runner.os }}-dot-cache-${{ hashFiles('Gemfile.lock') }}
restore-keys: |
2025-06-26-09-${{ runner.os }}-dot-cache
2025-06-26-09-${{ runner.os }}-dot-cache-
path: |
/home/runner/.cache/solargraph
- name: Install gem types
run: bundle exec rbs collection install
- name: Typecheck self
Expand Down
Loading