Skip to content

chore: Restructure the integration tests #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 29, 2025
Merged

chore: Restructure the integration tests #646

merged 9 commits into from
Oct 29, 2025

Conversation

@Pijukatel
Copy link
Contributor

@Pijukatel Pijukatel commented Oct 24, 2025 •
edited
Loading

Description

  • Split integration tests based on scope:

    • Actor tests
    • Apify API tests

  • Update test_actor_with_crawler_reboot to match crawlee 1.0.4

Issues

Closes: #632
Closes: #650

@github-actions github-actions bot added this to the 126th sprint - Tooling team milestone Oct 24, 2025
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Oct 24, 2025
@Pijukatel Pijukatel marked this pull request as ready for review October 29, 2025 08:26
@Pijukatel Pijukatel requested a review from vdusek October 29, 2025 08:26
@Pijukatel Pijukatel mentioned this pull request Oct 29, 2025
Closed
vdusek
vdusek reviewed Oct 29, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One more thing, could you please also update the tests/integration/README.md? It is outdated now. I would add a section at the beginning explaining the current structure and test types we have.

@Mantisus
Copy link
Collaborator

Mantisus commented Oct 29, 2025

This also closes #650.

@Pijukatel
Copy link
Contributor Author

Pijukatel commented Oct 29, 2025

Looks great! One more thing, could you please also update the tests/integration/README.md? It is outdated now. I would add a section at the beginning explaining the current structure and test types we have.

Updated

@Pijukatel Pijukatel requested a review from vdusek October 29, 2025 15:15
vdusek
vdusek approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek vdusek merged commit 0e03e0e into master Oct 29, 2025
21 checks passed
@vdusek vdusek deleted the restructure-integration-tests branch October 29, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdusek vdusek vdusek approved these changes

Assignees

@Pijukatel Pijukatel

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Milestone

126th sprint - Tooling team

Development

Successfully merging this pull request may close these issues.

Integration test test_actor_with_crawler_reboot is failing Restructure integration tests according to the integration level

4 participants

@Pijukatel @Mantisus @vdusek