fix(httpcache): collection iri invalidation for mapped entities #7353
+89
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrossard
force-pushed
the
fix-collection-iris-invalidation
branch
3 times, most recently
from
a31cfef to
77ee6c7
Compare
mrossard
force-pushed
the
fix-collection-iris-invalidation
branch
from
77ee6c7 to
3210bfb
Compare
|
@soyuka this version should be better. Next on this subject would be to add invalidation for non-doctrine stuff, but finding the correct moment to gather obsolete items / call the purge may be tricky. |
|
@mrossard this is quite easy to do manually with all the extension points thanks for the bug fix looks nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #7345. This version waits for the doctrine flush() before trying to map the inserted entites to resources, which should ensure we invalidate the related resource collections correctly.
The related test was also reworked, it didn't do what it should. On that point i'm not sure whether it's correct to prophesize the ObjectMapper...the test would be better with a real instance IMO, but i can't (yet?) figure out how to do that easily.