[SPARK-] Fix AnalysisContext being wiped during nested plan resolution #52330
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR:
Why are the changes needed?
Bug: when there are nested plans being analyzed, the AnalysisContext gets reset. When resolving rules after the AnalysisContext gets reset, it may cause unexpected behavior because origin AnalysisContext is no longer preserved.
This change preserves the AnalysisContext after the nested plan has been analyzed.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tested
TODO: need SPARK ticket + to talk with Spark experts regarding what unresolved plan to use to trigger nested plan
Was this patch authored or co-authored using generative AI tooling?
No