[SPARK-53547] [Python] Add make_timestamp_ntz overload with date/time parameters #52329
+173
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for make_timestamp_ntz(date=..., time=...) overload in PySpark. This implements SPARK-51162 to provide an alternative way to create local date-time values using separate date and time columns.
Yicong-Huang
changed the title
This reverts commit 579c45a.
| @@ -25155,10 +25175,14 @@ def make_timestamp_ntz( | |||
| mins : :class:`~pyspark.sql.Column` or column name | |||
| The minute-of-hour to represent, from 0 to 59 | |||
| secs : :class:`~pyspark.sql.Column` or column name | |||
| The second-of-minute and its micro-fraction to represent, from 0 to 60. | |||
| The second-of-minute and its micro-fraction to represent, from 0 to 60.. | |||
| ) -> Column: | ||
| """ | ||
| Create local date-time from years, months, days, hours, mins, secs fields. | ||
| Create local date-time from years, months, days, hours, mins, secs fields, or from date and time fields. | ||
| If the configuration `spark.sql.ansi.enabled` is false, the function returns NULL | ||
| on invalid inputs. Otherwise, it will throw an error instead. | ||
|
|
There was a problem hiding this comment.
Shall we add a .. versionchanged::?
There was a problem hiding this comment.
Sure! Which version should I use? (4.1?)
|
PR titles typically follow [SPARK-xxxxx][PYTHON].. |
…ror handling - Add WRONG_NUM_ARGS error class to error-conditions.json - Update make_timestamp_ntz in builtin.py to use PySparkValueError with WRONG_NUM_ARGS - Update make_timestamp_ntz in connect/builtin.py to use PySparkValueError with WRONG_NUM_ARGS - Update test cases to expect PySparkValueError with proper error class and message parameters
Yicong-Huang
changed the title
- Change error message from 'either all 6 components or both date and time' to '(years, months, days, hours, mins, secs) or (date, time)' - Update consistently across builtin.py, connect/builtin.py, and test_functions.py - Provides clearer guidance to users about expected parameter names
Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add support for make_timestamp_ntz(date=..., time=...) overload in PySpark. This implements SPARK-53547 to provide an alternative way to create local date-time values using separate date and time columns.
Why are the changes needed?
We need to align with Scala side API to make it flexible for users to create a timestamp with date and time.
Does this PR introduce any user-facing change?
New PySpark function.
How was this patch tested?
Added unit tests.
Was this patch authored or co-authored using generative AI tooling?
Tests Generated-by: Cursor