Skip to content

[SPARK-53552][SQL] Optimize substr SQL function #52308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −5
Open

[SPARK-53552][SQL] Optimize substr SQL function #52308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,9 +642,13 @@ public UTF8String substring(final int start, final int until) {
}

int j = i;
while (i < numBytes && c < until) {
i += numBytesForFirstByte(getByte(i));
c += 1;
if (until == Integer.MAX_VALUE) {
i = numBytes;
} else {
while (i < numBytes && c < until) {
i += numBytesForFirstByte(getByte(i));
c += 1;
}
}

if (i > j) {
Expand All @@ -663,9 +667,8 @@ public UTF8String substringSQL(int pos, int length) {
// refers to element i-1 in the sequence. If a start index i is less than 0, it refers
// to the -ith element before the end of the sequence. If a start index i is 0, it
// refers to the first element.
int len = numChars();
// `len + pos` does not overflow as `len >= 0`.
int start = (pos > 0) ? pos -1 : ((pos < 0) ? len + pos : 0);
int start = (pos > 0) ? pos -1 : ((pos < 0) ? numChars() + pos : 0);

int end;
if ((long) start + length > Integer.MAX_VALUE) {
Expand Down