[SPARK-53551][SQL] Improve OffsetAndLimit by avoiding duplicate evaluation
#52307
+19
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
OffsetAndLimit by avoiding duplicate evaluation
|
Thank you for pinging me, @beliefer . |
There was a problem hiding this comment.
At a first glance, this PR aims to replace offset + limit with localLimit simply?
A few Int add operations seems to be saved. Is there any other improvement, @beliefer ?
Yes.
No. But I added some comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to improve
OffsetAndLimitby avoiding duplicate evaluation.Why are the changes needed?
OffsetAndLimitdoesn't return the local limit (the same as offset + global limit), it lead to duplicate evaluation.Does this PR introduce any user-facing change?
'No'.
Inner change.
How was this patch tested?
GA tests.
Was this patch authored or co-authored using generative AI tooling?
'No'.