Skip to content

Conversation

andrii-marushchak
Copy link
Contributor

Did you read the Contributor Guide?

  • No, I haven't read it.

Is this PR related to a ticket?

  • No:
    • this is a documentation update. The PR name follows the format [DOCS] my subject

What changes were proposed in this PR?

New design for homepage

How was this patch tested?

Manual QA

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

@jiayuasu
Copy link
Member

@andrii-marushchak please run pre-commit run --all-files locally before commit. You can also add it to Git hook: https://pre-commit.com/#3-install-the-git-hook-scripts

Copy link

@ClayMav ClayMav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many minified files and external libraries included in this PR, can these be either referenced via link in the head or made to be part of the build step in CI as opposed to being committed to the repo?
All of the icons have numerical names, or one has gif.png, can these be replaced with words, descriptive? Also are they all licensed properly?
There are several different versions of the mountains image, can that be consolidated, and do we have this image as an SVG? Then we could just clip the image wherever necessary instead of duplicating
Also some docs on how to get this up and running would be nice.

Unnecessary duplication

Image

Probably leave more time between write word and delete word from the typewriter

Thank you - this looks excellent in my browser.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The favicon should be sedona's if this file is used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I removed all .min files
  • Renamed images to have proper names
  • mountains SVG image will be too large, .png is much smaller

Copy link
Contributor Author

@andrii-marushchak andrii-marushchak Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codespell errors have no sense - https://monosnap.com/file/2roVikvu6RevoWPu0dx9DrGl10nN4E
other errors are fixed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now in term of CI/CD we need to add a build of my extra css and js files
it should be something like this, when node.js is installed

cd docs-overrides
npm i
npm gulp -g
gulp build

@kadolor
Copy link
Collaborator

kadolor commented Sep 8, 2025

@andrii-marushchak

  • I downloaded the PR and am previewing it locally.
  • I ran pre-commit --all-files in sedona/docs and it returned failures on check-illegal-windows-names and codespell
  • The check-illegal-windows-names errors are below
  • The codespell errors are too long to include here so when you run pre-commit --all-files in sedona/docs, you can review the codespell output there.
run check-illegal-windows-names..........................................Failed
- hook id: check-illegal-windows-names
- exit code: 1

Illegal Windows filenames detected

docs/image/home/gif/gif.png:Zone.Identifier
docs/image/home/gif/giphy.gif:Zone.Identifier
docs/image/home/gif/petar-avramoski-GmlMtdSfmVU-unsplash.jpg:Zone.Identifier
docs/image/home/hero/mountains-desktop.png:Zone.Identifier
docs/image/home/mountains-desktop.png:Zone.Identifier
docs/image/home/mountains-mobile.png:Zone.Identifier

Copy link

@ClayMav ClayMav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one min.js file still remains, other comments are nits.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another min file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this also be an svg?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

converted to svg

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this also be an SVG? or even the same SVG as the above ones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

converted to svg

@jiayuasu jiayuasu requested a review from jbampton as a code owner September 12, 2025 15:40
@jiayuasu jiayuasu requested a review from ClayMav September 12, 2025 15:53
@sfishel18
Copy link

i see three files that look like they were copied from another location (that's a guess based on their structure/length/lack-of-whitespace, let me know if i'm incorrect):

  • docs-overrides/assets/javascripts/lunr/tinyseg.js
  • docs-overrides/assets/javascripts/lunr/wordcut.js
  • docs-overrides/assets/stylesheets/vendors/_highlightjs.scss

for each of these i would like us to either:

  1. find a way to get that file from an npm package instead, or
  2. document where the original file came from, why it can't be pulled in from npm, whether we modified it after copying it over, and a link to proof that its license is permissive enough to use it the way we are

@jiayuasu jiayuasu merged commit f2216ad into apache:master Sep 15, 2025
9 checks passed
jiayuasu added a commit that referenced this pull request Sep 24, 2025
* Started working oon a new homepage

* Finished page

* Fixed typed animation, adjusted tabs jumping

* Hid the reviews

* Changed industries logos, reduced header size

* Changed code in code tabs sections, removed typed cursor

* Upadted CTA heading

* Updated links in footer

* Fixed typed animation jumbping

* Run precommit

* added gulpfile and missing files

* Updated gitignore

* Removed .min files from repo

* Updated code tabs to prevent escaped html console errors

* Removed .min.map from the repo

* Removed windows .idenfier files

* Renamed Images

* Updated gulpfile and extra rousrces files

* Added delay between typying animation

* Removed .main.min.js and converted mountains images to SVGs

* Fix pre-commit

* Removed extra files

* Remorked template without overwriting base.html

* Fetching vendors from node_modules

* Add gulp to CI

* Fixed header & footer, js subscribe fix

* Added partials

* Added missing svg images

---------

Co-authored-by: Jia Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants