-
Notifications
You must be signed in to change notification settings - Fork 733
[DOCS] Homepage redesign #2296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Homepage redesign #2296
Conversation
@andrii-marushchak please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many minified files and external libraries included in this PR, can these be either referenced via link in the head or made to be part of the build step in CI as opposed to being committed to the repo?
All of the icons have numerical names, or one has gif.png, can these be replaced with words, descriptive? Also are they all licensed properly?
There are several different versions of the mountains image, can that be consolidated, and do we have this image as an SVG? Then we could just clip the image wherever necessary instead of duplicating
Also some docs on how to get this up and running would be nice.
Unnecessary duplication

Probably leave more time between write word and delete word from the typewriter
Thank you - this looks excellent in my browser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The favicon should be sedona's if this file is used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I removed all .min files
- Renamed images to have proper names
- mountains SVG image will be too large, .png is much smaller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codespell errors have no sense - https://monosnap.com/file/2roVikvu6RevoWPu0dx9DrGl10nN4E
other errors are fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now in term of CI/CD we need to add a build of my extra css and js files
it should be something like this, when node.js is installed
cd docs-overrides
npm i
npm gulp -g
gulp build
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one min.js file still remains, other comments are nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another min file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this also be an svg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
converted to svg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this also be an SVG? or even the same SVG as the above ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
converted to svg
i see three files that look like they were copied from another location (that's a guess based on their structure/length/lack-of-whitespace, let me know if i'm incorrect):
for each of these i would like us to either:
|
* Started working oon a new homepage * Finished page * Fixed typed animation, adjusted tabs jumping * Hid the reviews * Changed industries logos, reduced header size * Changed code in code tabs sections, removed typed cursor * Upadted CTA heading * Updated links in footer * Fixed typed animation jumbping * Run precommit * added gulpfile and missing files * Updated gitignore * Removed .min files from repo * Updated code tabs to prevent escaped html console errors * Removed .min.map from the repo * Removed windows .idenfier files * Renamed Images * Updated gulpfile and extra rousrces files * Added delay between typying animation * Removed .main.min.js and converted mountains images to SVGs * Fix pre-commit * Removed extra files * Remorked template without overwriting base.html * Fetching vendors from node_modules * Add gulp to CI * Fixed header & footer, js subscribe fix * Added partials * Added missing svg images --------- Co-authored-by: Jia Yu <[email protected]>
Did you read the Contributor Guide?
Is this PR related to a ticket?
[DOCS] my subject
What changes were proposed in this PR?
New design for homepage
How was this patch tested?
Manual QA
Did this PR include necessary documentation updates?