RANGER-5210: private variable isPolicyEngineShared is set to wrong value #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneethiraj
approved these changes
May 9, 2025
|
@vyommani please rebase PR to re-run the CI checks, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the RangerBasePlugin class, the isPolicyEngineShared variable is incorrectly set to true even when the policy engine instance isn't shared.
When delta sync is enabled, the PolicyRefresher downloads modified policies and updates the policy engine. If locking is enabled, it updates the existing policy engine instance; otherwise, it creates a new instance.
The setPolicies method creates a new policy engine instance by calling RangerPolicyEngineImpl.getPolicyEngine. However, this method might return the same instance, not a new one.
The isPolicyEngineShared flag is set to true if newPolicyEngine isn't null, which is incorrect. Instead, it should be set to true only if newPolicyEngine is the same instance as the old policy engine.
How was this patch tested?
I tested locally as follows
mvn clean install