Skip to content

Conversation

XN137
Copy link
Contributor

@XN137 XN137 commented Aug 28, 2025

since apache/iceberg@9bc6853 passing a hadoop Configuration to CatalogUtil.loadCatalog is optional.

since hadoop-common brings in a lot of dependencies (and thus potential vulnerabilities) we should avoid depending on it in our core modules if not strictly required.

note that we were using the transitive commons-collections dependency in a spot that we have to adjust.

@github-project-automation github-project-automation bot moved this to PRs In Progress in Basic Kanban Board Aug 28, 2025
@XN137 XN137 marked this pull request as ready for review August 28, 2025 08:45
adutra
adutra previously approved these changes Aug 28, 2025
@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Aug 28, 2025
dimas-b
dimas-b previously approved these changes Aug 28, 2025
@dimas-b dimas-b requested a review from dennishuo August 28, 2025 20:48
since apache/iceberg@9bc6853
passing a hadoop Configuration to `CatalogUtil.loadCatalog` is optional.

since `hadoop-common` brings in a lot of dependencies (and thus
potential vulnerabilities) we should avoid depending on it in our core
modules if not strictly required.

note that we were using the transitive `commons-collections` dependency
in a spot that we have to adjust.
@XN137 XN137 dismissed stale reviews from dimas-b and adutra via ccb89bb August 29, 2025 08:26
@XN137 XN137 force-pushed the reduce-hadoop-common branch from 7d252b2 to ccb89bb Compare August 29, 2025 08:26
@XN137
Copy link
Contributor Author

XN137 commented Aug 29, 2025

rebased after trivial merge conflict in IcebergCatalogHandlerAuthzTest.java

@flyrain flyrain merged commit 17a359b into apache:main Aug 29, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Aug 29, 2025
@XN137 XN137 deleted the reduce-hadoop-common branch August 30, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants