Skip to content

Conversation

MonkeyCanCode
Copy link
Contributor

This PR remove the use/needed of SCRIPT_DIR and change the default config location to user home (~/.polaris/)

@eric-maynard
Copy link
Contributor

IIRC I used the home directory in an earlier version of the CLI, but this caused issues with multiple Polaris environments conflicting. Keeping the venv and everything within the Polaris directory actually seems like a good thing to me, what do we gain by using home instead?

@MonkeyCanCode
Copy link
Contributor Author

I think the problem with Polaris directory is for users who only want to use CLI and not downloading the entire code base, there won't be a repo path for them to use. Maybe we can allow users to specify where to put as an overwrite?

IIRC I used the home directory in an earlier version of the CLI, but this caused issues with multiple Polaris environments conflicting. Keeping the venv and everything within the Polaris directory actually seems like a good thing to me, what do we gain by using home instead?

@eric-maynard
Copy link
Contributor

+1 to allowing a custom location, good idea. We could also default to something like ~/.local/lib or /usr/local/ if you think that's better than SCRIPT_DIR as a default.

@MonkeyCanCode
Copy link
Contributor Author

Sounds good. Let me draft something later this week then ask for review again. Thanks.

+1 to allowing a custom location, good idea. We could also default to something like ~/.local/lib or /usr/local/ if you think that's better than SCRIPT_DIR as a default.

@MonkeyCanCode
Copy link
Contributor Author

to allowing a custom location, good idea. We could also default to something like ~/.local/lib or /usr/local/ if you think that's better than SCRIPT_DIR as a default.

@eric-maynard do you mind take another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants