Pass related entity to PolarisStorageIntegrationProvider #2437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PolarisStorageIntegrationProvider used to operate on a `PolarisStorageConfigurationInfo` instance extracted from the related entity by the caller. This change delegated this config extraction to the implementations of the `PolarisStorageIntegrationProvider` interface. The main purpose of this change is to allow implementations to have more flexibility by being able to inspect the whole entity that contains storage info. The default `PolarisStorageIntegrationProvider` implementation works as before. There is no behaviour change in Polaris from the clients' perspective. As a side effect, `IntegrationPersistence` and `TransactionalPersistence` interfaces also had to be changed to propagate related entities to `PolarisStorageIntegrationProvider`.
dimas-b
force-pushed
the
storage-config-loader-plugin
branch
from
fe9a04f to
46d3b5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PolarisStorageIntegrationProvider used to operate on a
PolarisStorageConfigurationInfoinstance extracted from the related entity by the caller.This change delegated this config extraction to the implementations of the
PolarisStorageIntegrationProviderinterface.The main purpose of this change is to allow implementations to have more flexibility by being able to inspect the whole entity that contains storage info.
The default
PolarisStorageIntegrationProviderimplementation works as before. There is no behaviour change in Polaris from the clients' perspective.As a side effect,
IntegrationPersistenceandTransactionalPersistenceinterfaces also had to be changed to propagate related entities toPolarisStorageIntegrationProvider.