Skip to content

Conversation

lordgamez
Copy link
Contributor

https://issues.apache.org/jira/browse/MINIFICPP-2232


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@lordgamez lordgamez force-pushed the MINIFICPP-2232 branch 3 times, most recently from 6164f69 to 3431103 Compare July 2, 2025 10:57
@lordgamez
Copy link
Contributor Author

lordgamez commented Jul 2, 2025

With the removed dependencies the order of the includes changed and it caused an issue with the Windows DELETE macro being undefined due to the conflicting HttpRequestMethod::DELETE enum. It seemed to be a cleaner solution to remove the issue entirely by renaming the method enum values in a05a882

@lordgamez lordgamez marked this pull request as ready for review July 2, 2025 16:00
@lordgamez lordgamez force-pushed the MINIFICPP-2232 branch 2 times, most recently from 817c19e to 400b270 Compare August 25, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants