Skip to content

Fix EL ResourceBundle preview panel #8603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NicolaIsotta
Copy link
Contributor

@NicolaIsotta NicolaIsotta commented Jun 18, 2025

Before:
image
After:
image

This also makes the "Open source in editor button" works and fixes the load of bundle files from the default package / root folder.


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@mbien mbien added Editor enterprise [ci] enable enterprise job ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jun 18, 2025
@mbien mbien added this to the NB27 milestone Jun 18, 2025
@NicolaIsotta NicolaIsotta marked this pull request as draft June 18, 2025 10:57
@NicolaIsotta NicolaIsotta marked this pull request as draft June 18, 2025 10:57
@NicolaIsotta
Copy link
Contributor Author

Marking this as draft as there's another fix I'd like to make about bundle resolution

@mbien
Copy link
Member

mbien commented Jun 19, 2025

nice! I like those quality of life improvements.

Fix "Open source in editor button"
Fix loading of bundle files from default package
@
@NicolaIsotta NicolaIsotta marked this pull request as ready for review June 19, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Editor enterprise [ci] enable enterprise job
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants