Ability to depend on JDK modules #291
Conversation
|
To me, looks good. Any comments/feedback from anyone? |
|
@jlahoda Are we expecting any progress on this? Or just close this one? |
There was a problem hiding this comment.
I like the approach a lot. Modularized JDK is here to stay and getting ready for it is great. It is fantastic that it also works on JDK8. That gives us smooth migration path to JDK modules, without forcing us to drop JDK8!
The code needs some more polishing (I've noticed some debug messages and reading of a file from the source structure), but overall the approach is great.
|
@lkishalmi I would love to see some progress, but didn't have much time for quite some time. If you prefer, we can close this - it is easy to reopen or open a new PR after all. |
|
Hi @jlahoda can you rebase this one on the current master, if it is still relevan. Let's not have this one bitrot in here... |
This is a work-in-progress patch, mostly for discussion, not intended to be merged as is.
The goal here is to allow NetBeans modules (modules in the NetBeans Module System) depend on JDK modules. As a result dependencies on JDK modules are much more precise. Some more information is here:
https://cwiki.apache.org/confluence/display/NETBEANS/JDK+Modules+Support+in+NetBeans+Module+System
There are 3 commits in this request, the middle one " Automatically adding JDK module dependencies to existing modules." is mechanically generated, based on jdeps output for the given module.
Feedback is welcome.