Fix #10950: Replace raw RuntimeException on reactor cycle with ProjectBuildingExc… #11091
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturobernalg
changed the title
elharo
reviewed
Sep 3, 2025
| final ProjectCycleException pce = new ProjectCycleException( | ||
| "The projects in the reactor contain a cyclic reference: " + cycle.getMessage(), cde); | ||
|
|
||
| // If you can resolve these from the problem/result, set them; otherwise leave null. |
There was a problem hiding this comment.
This comment doesn't seem right. They can't be set here.
| "The projects in the reactor contain a cyclic reference: " + cycle.getMessage(), | ||
| (CycleDetectedException) cycle.getException())); | ||
| pomFile, | ||
| pce); |
There was a problem hiding this comment.
I'm not clear why pce was created. Could you just pass the cde here?
…; keep CycleDetectedException as cause. Non-cycle model problems still use ProjectBuildingException(results). Remove misleading comment about projectId/pomFile.
|
please do another pass |
gnodet
approved these changes
Sep 3, 2025
elharo
reviewed
Sep 17, 2025
| @@ -492,10 +491,14 @@ List<ProjectBuildingResult> build(List<File> pomFiles, boolean recursive) throws | |||
| .findAny() | |||
| .orElse(null); | |||
| if (cycle != null) { | |||
| throw new RuntimeException(new ProjectCycleException( | |||
| final CycleDetectedException cde = (CycleDetectedException) cycle.getException(); | |||
There was a problem hiding this comment.
The wrapping still smells like something's not quite right. The code is quite complex, and it might be simpler without the lambda, but either way we really should be able to just throw the CycleDetectedException. This is not a public method so we can easily add that to the method signature. It's also possible CycleDetectedException should be a subclass of ProjectBuildingException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eption.
When a reactor dependency cycle is detected, wrap the underlying org.codehaus.plexus.util.dag.CycleDetectedException in a new ProjectCycleException and throw a checked ProjectBuildingException (as declared by ProjectBuilder) instead of a raw RuntimeException.
Keep non-cycle model problems on the existing ProjectBuildingException(results) path.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.