-
Notifications
You must be signed in to change notification settings - Fork 290
Tidied up download page #1426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Tidied up download page #1426
Conversation
|
Ah. Sorry. I messed up. That is more than one commit. Even one that shouldn't belong here. I will try to sequeeze it into again. |
It was added earlier this year (#719) as there is no other download page for Daemon. And I think it's fine. It's a (and the only which needs external download) tool by the Maven team and of Maven. -- We should make sure use this PR to also fix headings On live page it is:
This violates basic rules of HTML where only one H1 is allowed for the page title, which is not Downloading Maven 3.9.11 but should "Downloding Apache Maven - Maven" according to title tag. I think "Downloading Maven" is better. The then following structure should be something like this
And also add a TOC to the page so users can jump to the section they want |
Your proposal also has two H1s. Mistake? H1: Download Maven Like this? |
opps yeah and the one below then H3. Will edit. edit: also renamed PR title cause it's about download page |
|
When you update your PR, please rebase it - the current diff contains a lot of changes from earlier/merged PRs. Thank you! |
| However, this still required the usage of the [Flatten Maven Plugin][20] for full functionality. | ||
| Since Maven 4, no additional plugin is needed; full built-in support is provided. | ||
| You can now use variables as versions in your configuration. | ||
| You can now use **any variable** as versions in your configuration, not just predefined ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a version
|
|
||
| ### Maven Upgrade Tool | ||
|
|
||
| If you're currently using Maven 3 and want to upgrade to Maven 4, you can use the [Maven Upgrade Tool](https://maven.apache.org/tools/mvnup.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"If you're currently using Maven 3 and want to upgrade to Maven 4" -- "To upgrade from maven 3 to Maven 4"
|
|
||
| The Maven Upgrade Tool tool can be used to: | ||
|
|
||
| * Automatically update your POM files to use the new model version 4.1.0 (if desired) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete "Automatically"
|
|
||
| * Automatically update your POM files to use the new model version 4.1.0 (if desired) | ||
| * Identify deprecated features and suggest replacements | ||
| * Help migrate from deprecated plugin configurations to their modern equivalents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete "Help"
* System requirements are now less dominant * Maven Maven Daemon has its own section * Removed other releases into Apache Maven and Daemon section * Swapped the positions of Maven 4.x and 3.8.x releases
I messed up. Your comments ended up on the wrong PR. My bad. |
I like all your idea, but I am a bit stuck at the moment. Haven't figured out this whole Velocity and Maven Fluido Skin combination. |
sure, just ping me if you want another review or help (not sure where you are stucked exactly atm) |
|
Hi @Bukama thanks for getting in touch. Very much appreciated. Here is where I am stuck at the moment. I am trying to implement your proposal: H1 Download Maven dnd also add a TOC to the page so users can jump to the section they want. The file I haven't figured out where the whole magic happens. renders a H1 . renders a h2. There is no And I haven't looked into deeply enough into the templating stuff long enough to find out if there is a TOC element or macro. Not sure what the proper naming is. |
|
Please wait for I'm going to merge it at the end of month |
For TOC you can use the following in
You should be able to just work with as the base is still Hope this helps, otherwise I would have to have a closer look myself tomorrow. |
Sure :) |
|
@raupachz The 3.8 EOL has been merged, you can update the PR if you want :) |
Hello,
my try on improving the Downloads page.
System requirements are now inline with the text. I don't think there is a need for everything mentioned and it is less visually dominated now.
Other releases is removed and its content is moved into Apache Maven and Maven Daemon. Daemon got its own section. If it were my call I would even go as far and drop Maven Daemon from the Downloads page. Not saying it is great tech, but the page is about downloading Maven not about Daemon.
I swapped the position of 4.x and older 3.8.x. I think this is better. Always nice to show that things are moving forward, but not ignoring the older versions.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
mvn siteand examine output intarget/sitedirectory.Site will also be built on your pull request automatically and attached to GitHub Action result.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.