Skip to content

KAFKA-19793 Adding allow topic creation false for global and restore consumer #20723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
+52 −5
Open

KAFKA-19793 Adding allow topic creation false for global and restore consumer #20723

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
690a974
Adding allow topic creation false for global and restore consumer
iit2009060 Oct 17, 2025
789bb13
adding test whivh verify override does not work
iit2009060 Oct 18, 2025
3779545
Adding auto create topic in non configurable default
iit2009060 Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1845,6 +1845,9 @@ public Map<String, Object> getRestoreConsumerConfigs(final String clientId) {
baseConsumerProps.put(CommonClientConfigs.CLIENT_ID_CONFIG, clientId);
baseConsumerProps.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "none");

// disable auto topic creation
baseConsumerProps.put(ConsumerConfig.ALLOW_AUTO_CREATE_TOPICS_CONFIG, "false");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we add this to NON_CONFIGURABLE_CONSUMER_DEFAULT_CONFIGS and also set it centrally in getCommonConsumerConfigs() ?

For this case, we can also remove the corresponding line in getMainConsumerConfigs()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjsax Done the changes.


return baseConsumerProps;
}

Expand Down Expand Up @@ -1877,6 +1880,10 @@ public Map<String, Object> getGlobalConsumerConfigs(final String clientId) {
// add client id with stream client id prefix
baseConsumerProps.put(CommonClientConfigs.CLIENT_ID_CONFIG, clientId + "-global-consumer");
baseConsumerProps.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "none");

// disable auto topic creation
baseConsumerProps.put(ConsumerConfig.ALLOW_AUTO_CREATE_TOPICS_CONFIG, "false");

return baseConsumerProps;
}

Expand Down
26 changes: 26 additions & 0 deletions streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,32 @@ public void shouldOverrideAdminDefaultAdminClientEnableTelemetry() {
assertTrue((boolean) returnedProps.get(AdminClientConfig.ENABLE_METRICS_PUSH_CONFIG));
}

@Test
public void testAutoCreateTopicsCannotBeOverriddenForStreamsConsumers() {
// User tries to override the setting
props.put(StreamsConfig.restoreConsumerPrefix(ConsumerConfig.ALLOW_AUTO_CREATE_TOPICS_CONFIG), "true");
props.put(StreamsConfig.globalConsumerPrefix(ConsumerConfig.ALLOW_AUTO_CREATE_TOPICS_CONFIG), "true");
props.put(StreamsConfig.mainConsumerPrefix(ConsumerConfig.ALLOW_AUTO_CREATE_TOPICS_CONFIG), "true");

final StreamsConfig streamsConfig = new StreamsConfig(props);

// Main consumer - verify override is ignored
final Map<String, Object> mainConfigs = streamsConfig.getMainConsumerConfigs("group", "client", 0);
assertEquals("false", mainConfigs.get(ConsumerConfig.ALLOW_AUTO_CREATE_TOPICS_CONFIG),
"Main consumer should not allow auto topic creation even with override");

// Restore consumer - verify override is ignored
final Map<String, Object> restoreConfigs = streamsConfig.getRestoreConsumerConfigs("client");
assertEquals("false", restoreConfigs.get(ConsumerConfig.ALLOW_AUTO_CREATE_TOPICS_CONFIG),
"Restore consumer should not allow auto topic creation even with override");

// Global consumer - verify override is ignored
final Map<String, Object> globalConfigs = streamsConfig.getGlobalConsumerConfigs("client");
assertEquals("false", globalConfigs.get(ConsumerConfig.ALLOW_AUTO_CREATE_TOPICS_CONFIG),
"Global consumer should not allow auto topic creation even with override");
}


@Test
public void shouldSupportNonPrefixedAdminConfigs() {
props.put(AdminClientConfig.DEFAULT_API_TIMEOUT_MS_CONFIG, 10);
Expand Down