Skip to content

Conversation

@eduwercamacaro
Copy link
Contributor

Delete this text and replace it with a detailed description of your change. The
PR title and body will become the squashed commit message.

If you would like to tag individuals, add some commentary, upload images, or
include other supplemental information that should not be part of the eventual
commit message, please use a separate comment.

If applicable, please include a summary of the testing strategy (including
rationale) for the proposed change. Unit and/or integration tests are expected
for any behavior change and system tests should be considered for larger
changes.

@github-actions github-actions bot added triage PRs from the community streams labels Oct 15, 2025
@Nikita-Shupletsov
Copy link
Contributor

thanks @eduwercamacaro

I wrote a test that verifies that metrics are published: https://github.com/apache/kafka/pull/20570/files#diff-a8f919d43ec1cebdb136acf94adfbeb20fef0cda0ad5d29b7010e0186b355d71
I tired to run it with this change, but, unfortunately, it didn't work, and I couldn't quickly figure out why...
just a heads-up

@eduwercamacaro
Copy link
Contributor Author

Hi @Nikita-Shupletsov Thanks for your time checking these changes. 😄

Unfortunately, this PR contains too many changes that I need to clean up, and it is not particularly easy to follow. I am working on some cleanups to make it easier to read.

Thank you for pointing out the integration test. If possible, I'll try to make these changes pass after the cleanup.

@Nikita-Shupletsov
Copy link
Contributor

sounds good!
please let me know if I can help

@eduwercamacaro
Copy link
Contributor Author

Hi @Nikita-Shupletsov
I made a new PR (#20749). In that case, the PR works more like a proposal than an experiment. Since I made this PR just as an experiment, it has too many changes that aren't needed. I’m very sorry to move this conversation.

The integration test that you mentioned was extremely useful for me to understand the problem. I copy-pasted your test in this branch and the test passes. check this change

Can you please take a look on that PR?

Thanks for your help on this. I'm trying to explore all the options to implement KIP-1035 and I believe my proposal also solves KAFKA-19434.

@eduwercamacaro
Copy link
Contributor Author

Closed in favor of #20749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

streams triage PRs from the community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants