MINOR: Fix failed e2e compatibility_test_new_broker_test and upgrade_test.py #20471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
chia7712
reviewed
Sep 3, 2025
| # For backward compatibility, we select the configuration based on node version: | ||
| # - For versions 4.2.0 and above, use --command-config | ||
| # - For older versions, continue using --producer.config | ||
| if node.version >= V_4_2_0: |
There was a problem hiding this comment.
Could you please consider adding a helper method to KafkaVersion?
There was a problem hiding this comment.
Good idea. I have changed to use the new helper method.
omkreddy
reviewed
Sep 4, 2025
There was a problem hiding this comment.
I have added another comment here: https://github.com/apache/kafka/pull/20390/files#r2321634022
| @@ -424,7 +424,16 @@ def start_cmd(self, node): | |||
| if self.max_messages > 0: | |||
| cmd += " --max-messages %s" % str(self.max_messages) | |||
|
|
|||
| cmd += " --command-config %s" % VerifiableConsumer.CONFIG_FILE | |||
| version = get_version(node) | |||
| # According to KIP-1147, --consumer.config has been deprecated and will be removed in future versions. | |||
There was a problem hiding this comment.
Can we move these comments to version.supports_command_config() method?
There was a problem hiding this comment.
@omkreddy Thanks for your comments, sorry for my carelessness and I have addressed them.
JimmyWang6
force-pushed
the
KAFKA-19625-1
branch
from
c9aee70 to
f1d2c19
Compare
JimmyWang6
force-pushed
the
KAFKA-19625-1
branch
from
388b62b to
d30fbca
Compare
omkreddy
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20390 Replace the -
-producer.configfor the verifiable producer and--consumer.configoption by--command-configfor the verifiable consumer. However, for e2e tests targeting older broker versions, the original configuration should still be used.Fix the following tests:
consumer_protocol_migration_test.py、compatibility_test_new_broker_test.pyandupgrade_test.py.My local test result before change:
After: