KAFKA-18706: Move ScramPublisher to metadata module #20468
+80
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
see-quick
changed the title
mimaison
reviewed
Sep 5, 2025
metadata/src/main/java/org/apache/kafka/metadata/publisher/ScramPublisher.java
Outdated
Show resolved
Hide resolved
metadata/src/main/java/org/apache/kafka/metadata/publisher/ScramPublisher.java
Outdated
Show resolved
Hide resolved
server-common/src/main/java/org/apache/kafka/server/common/CredentialProvider.java
Outdated
Show resolved
Hide resolved
mimaison
reviewed
Sep 5, 2025
Comment on lines
+56
to
+57
| scramDelta.changes().forEach((mechanism, userChanges) -> { | ||
| userChanges.forEach((userName, change) -> { |
There was a problem hiding this comment.
In both cases, the body of the block is a single expression, so we can remove the brackets{ }
There was a problem hiding this comment.
Also, this could be added to checkstyle, I assume. Updated.
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
… admins scramMechanism) Signed-off-by: see-quick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the ScramPublisher class from the server metadata package
to the dedicated metadata module. During refactoring, I found out that I
also need to move the CredentialProvider interface to a more appropriate
location in the server common package because
CredentialProvideris inthe
servermodule, and I can't include that module in themetadatabecause I would create a circular dependency, i.e.,
server module ←-------------┐ ↓ (depends on). │
(which would make it circular) metadata module------------┘
So I have moved
CredentialProvidertoserver-commonmodule, andmetadatamodule has alreadyserver-commonand thus it's resolved.