KAFKA-19666: Remove old restoration codepath from KafkaStreamsTelemetryIntegrationTest [1/N] #20462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
shashankhs11
commented
Sep 2, 2025
| @@ -444,7 +444,7 @@ private List<String> getTaskIdsAsStrings(final KafkaStreams streams) { | |||
| .toList(); | |||
| } | |||
|
|
|||
| private static Stream<Arguments> singleAndMultiTaskParameters() { | |||
| private static Stream<Arguments> topologyComplexityAndRebalanceProtocol() { | |||
There was a problem hiding this comment.
Renamed to topologyComplexityAndRebalanceProtocol as per #19275 (comment)
There was a problem hiding this comment.
Pull Request Overview
This PR removes the state-updater configuration parameter from telemetry integration tests, simplifying test methods by eliminating the boolean parameter that controlled state updater enablement. The changes align with cleanup efforts for state-updater related integration tests.
- Removed
stateUpdaterEnabledparameter from test methods and helper functions - Simplified parameterized test methods to focus on topology complexity and rebalance protocol
- Converted one parameterized test to a simple test method with hardcoded classic protocol
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lucasbru
approved these changes
Sep 3, 2025
| streamsApplicationProperties.put(StreamsConfig.STATE_DIR_CONFIG, TestUtils.tempDirectory(appId).getPath() + "-ks1"); | ||
| streamsApplicationProperties.put(StreamsConfig.CLIENT_ID_CONFIG, appId + "-ks1"); | ||
|
|
||
|
|
||
| streamsSecondApplicationProperties = props(stateUpdaterEnabled, groupProtocol); | ||
| streamsSecondApplicationProperties = props("classic"); |
shashankhs11
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up
KafkaStreamsTelemetryIntegrationTest.javaReviewers: Lucas Brutschy [email protected]