KAFKA-19658: Tweak org.apache.kafka.clients.consumer.OffsetAndMetadata #20451
+36
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
| * Normalizes leader epoch values for comparison and hashing. | ||
| * Both null and negative values are considered equivalent (representing absent/unknown epoch). | ||
| */ | ||
| private Integer normalizeLeaderEpoch(Integer leaderEpoch) { |
There was a problem hiding this comment.
nit: Since this method doesn't use any instance members we can make it static
or remove the leaderEpoch parameter.
Comment on lines
102
to
109
| /** | ||
| * Normalizes leader epoch values for comparison and hashing. | ||
| * Both null and negative values are considered equivalent (representing absent/unknown epoch). | ||
| */ | ||
| private Integer normalizeLeaderEpoch(Integer leaderEpoch) { | ||
| return (leaderEpoch == null || leaderEpoch < 0) ? null : leaderEpoch; | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we use the existing leaderEpoch method to normalize the leaderEpoch? It already maps null and negatives to Optional.empty().
+1 |
chia7712
reviewed
Sep 3, 2025
| assertEquals(5, consumer.committed(Set.of(TP)).get(TP).offset()); | ||
| metadata = consumer.committed(Set.of(TP)).get(TP); | ||
| assertEquals(5, metadata.offset()); | ||
| assertEquals("metadata", metadata.metadata()); |
There was a problem hiding this comment.
Please update the docs of OffsetAndMetadata#metadata() to remind that the method never return null
chia7712
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
equals(),hashCode(), andtoString()methods inOffsetAndMetadata.Reviewers: TengYao Chi [email protected], Sean Quah
[email protected], Chia-Ping Tsai [email protected]